Refactor DataGridViewColumnCollection to replace ArrayList #8153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
elachlan
commented
Nov 9, 2022
src/System.Windows.Forms/src/System/Windows/Forms/DataGridViewColumnCollection.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
auto-merge was automatically disabled
November 10, 2022 01:44
Head branch was pushed to by a user without write access
|
@RussKie sorry, the test failures were due to a test failure I had to change. I had to push the change which has stopped the automerge, hopefully the change is okay? |
RussKie
reviewed
Nov 10, 2022
src/System.Windows.Forms/src/System/Windows/Forms/DataGridViewColumnCollection.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/DataGridViewColumnCollection.cs
Outdated
Show resolved
Hide resolved
…ColumnCollection.cs
…ColumnCollection.cs
RussKie
approved these changes
Nov 10, 2022
|
flaky test? |
Yes, #7333. |
gpetrou
reviewed
Nov 10, 2022
| @@ -20,7 +20,7 @@ public void DataGridViewColumnCollection_Ctor_DataGridView() | |||
| Assert.Same(control, collection.DataGridView); | |||
| Assert.False(collection.IsReadOnly); | |||
| Assert.False(collection.IsSynchronized); | |||
| Assert.IsType<ArrayList>(collection.List); | |||
| Assert.True(collection.List is ArrayList); | |||
There was a problem hiding this comment.
Would IsAssignableFrom work here?
There was a problem hiding this comment.
Perhaps change it in another future PR? It should give a more meaningful message in case it fails.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
DataGridViewColumnCollectionto replaceArrayListwithList<T>Related: #8140
Microsoft Reviewers: Open in CodeFlow