Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PrintDialogDesigner.cs #9595

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Jul 28, 2023

Related to #4908

Proposed changes

  • Port MonthCalendarDesigner to runtime

Customer Impact

  • PrintDialogDesigner can be designed in runtime

Regression?

  • No

Risk

  • Minimal

Screenshots

Before

The default value of the property "UseEXDialog" is false
image

After

The default value of the property "UseEXDialog" is true
image

Test methodology

  • Manually (added PrintDialogDesigner to DemoConsole test app)

Test environment(s)

  • .Net 8.0.100-rc.1.23375.11
  • Windows 10 Enterprise 22H2
Microsoft Reviewers: Open in CodeFlow

@dmitrii-drobotov dmitrii-drobotov added the waiting-author-feedback The team requires more information from the author label Jul 28, 2023
@Tanya-Solyanik Tanya-Solyanik added this to the .NET 9.0 milestone Jul 28, 2023
SimonZhao888
SimonZhao888 previously approved these changes Jul 31, 2023
@dmitrii-drobotov dmitrii-drobotov added waiting-author-feedback The team requires more information from the author and removed waiting-author-feedback The team requires more information from the author labels Jul 31, 2023
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I added only minor comments.

@ghost ghost removed the waiting-author-feedback The team requires more information from the author label Aug 1, 2023
@Tanya-Solyanik Tanya-Solyanik added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Aug 1, 2023
@LeafShi1 LeafShi1 merged commit b22cfe2 into feature/9.0 Aug 2, 2023
@LeafShi1 LeafShi1 deleted the Issue_Related1908_Port_PrintDialogDesigner branch August 2, 2023 01:53
@ghost ghost removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Aug 2, 2023
@Amy-Li03
Copy link
Contributor

Verified this on feature/9.0 branch, now the default value of the property "UseEXDialog" for PrintDialog is true.
image

@ghost ghost locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants