Skip to content

Commit

Permalink
use StringSplitOptions.TrimEntries instead of seprate Trim() (halgab)
Browse files Browse the repository at this point in the history
  • Loading branch information
h3xds1nz committed Aug 24, 2024
1 parent 4f80699 commit 2b4a984
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -637,11 +637,11 @@ private void ReadAttributes(XmlReader reader)

case AnnotationXmlConstants.Attributes.TypeName:
ReadOnlySpan<char> typeName = value.AsSpan();
int segmentsLength = typeName.Split(segments, Colon);
int segmentsLength = typeName.Split(segments, Colon, StringSplitOptions.TrimEntries);

if (segmentsLength == 1) // Contains only name
{
ReadOnlySpan<char> name = typeName[segments[0]].Trim();
ReadOnlySpan<char> name = typeName[segments[0]];
if (name.IsEmpty)
{
// Just a string of whitespace (empty string doesn't get processed)
Expand All @@ -651,8 +651,8 @@ private void ReadAttributes(XmlReader reader)
}
else if (segmentsLength == 2) //Contains both namespace:name
{
ReadOnlySpan<char> @namespace = typeName[segments[0]].Trim();
ReadOnlySpan<char> name = typeName[segments[1]].Trim();
ReadOnlySpan<char> @namespace = typeName[segments[0]];
ReadOnlySpan<char> name = typeName[segments[1]];
if (@namespace.IsEmpty || name.IsEmpty)
{
// One colon, prefix or suffix is empty string or whitespace
Expand Down

0 comments on commit 2b4a984

Please sign in to comment.