Skip to content

arcade sdk version issue build failures in 'official/dnceng/dotnet-wpf-int/refs/heads/master' - '20190503.7' #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robertborr opened this issue May 3, 2019 · 2 comments
Assignees
Labels
area-infrastructure Bug Product bug (most likely)
Milestone

Comments

@robertborr
Copy link

@dotnet-mc-bot commented on Fri May 03 2019

There were a set of failures during this build. Here is a summary of these:

@robertborr

@vatsan-madhavan vatsan-madhavan self-assigned this May 3, 2019
@vatsan-madhavan
Copy link
Member

Looking....

vatsan-madhavan added a commit that referenced this issue May 3, 2019
…ound (#640)

* Updating SdkReferences.targets so that LimitNetCoreAppReferences runs earlier than ResolveAssemblyReferences, after ResolveTargetingPacks. To ensure this happens, updating Sdk targets by bumping version in global.json to Preview 5 candidate.

It creates a side effect during nuget-restore for test-builds - adding a workaround for that. This side-effect nuget failure will go away when we fix our tests to use Microsoft.NET.Sdk (verified locally that this is so).

* We no longer need the private C++/CLI frontend - the current Dev16.1 P2 builds that are already on the build servers have the right tools. Removing that workaround.

* Proactively exclude RuntimeFrameworkVersion when $(WpfTest)==true

* Add temporary workaround for missing System.Runtime.CompilerServices.SuppressMergeCheckAttribute in System.Runtime

* LimitNetCoreAppReferences should now deal in @(Reference) which is the output from ResolveTargetingPacks - and not in @(ReferencePath)

Also There is no longer an OriginalItemSpec - so make up our own
@vatsan-madhavan
Copy link
Member

This has been fixed by #652, #640, #638

@vatsan-madhavan vatsan-madhavan added area-infrastructure Bug Product bug (most likely) labels May 4, 2019
@vatsan-madhavan vatsan-madhavan added this to the Preview milestone May 4, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure Bug Product bug (most likely)
Projects
None yet
Development

No branches or pull requests

2 participants