Use ReadOnlyCollection.Empty #10013
Merged
Use ReadOnlyCollection.Empty #10013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
h3xds1nz
reviewed
Oct 29, 2024
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Controls/TextBlock.cs
Outdated
Show resolved
Hide resolved
Symbai
reviewed
Oct 29, 2024
src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/ManipulationDevice.cs
Show resolved
Hide resolved
harshit7962
added
Status:Completed
and removed
Status:InProgress
Status:Proposed
labels
…yCollection.Empty # Conflicts: # src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Schema/MemberReflector.cs # src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/XamlMember.cs
|
I pulled main to fix the conflicts. |
…yCollection.Empty # Conflicts: # src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/XamlType.cs
|
I pulled main to fix the conflicts. |
|
Thank you, @ThomasGoulet73, for your consistent and valuable contributions. Your hard work is greatly appreciated! 😄 |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces ReadOnlyCollection allocations with a shared singleton. I also replaced EmptyList with ReadOnlyCollection.Empty because it does the same thing, is a BCL API and allows to potentially allocate less ReadOnlyCollection instances.
Customer Impact
Better perf and memory usage.
Regression
None.
Testing
Local testing.
Risk
Low.