[StyleCleanUp] Addressing CA warnings Part 1

[himgoyalmicro]

Description

This work is a part of our initiative to set code-style guidelines, align WPF and WinForms, and ensure PR standards with respect to styles. This in turn will help us in better maintainability and readability of the repo overall. The changes follow up from the PR #10080 and references to the issue #10017.

The current changes address the following Errors/Warnings in the src folder of WPF:

• CA2249: Consider using 'string.Contains' instead of 'string.IndexOf'
• CA2251: Use String.Equals over String.Compare
• CA1847: Use string.Contains(char) instead of string.Contains(string) with single characters
• CA1845: Use span-based 'string.Concat'
• CA1846: Prefer AsSpan over Substring

A good way to go about reviewing this is to go commit by commit which pans over individual errors/warnings and hence easing out the overall understanding.

Customer Impact

None

Regression

None

Testing

Local Build Pass
The current set of changes looks fairly mechanical and probably don't need a Test Pass, but these set of PRs can be clubbed to do so at a later stage.

Risk

Low

Microsoft Reviewers: Open in CodeFlow

[harshit7962]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).