Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CommandHandler registration issue identified by DRT failure #1025

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Fix CommandHandler registration issue identified by DRT failure #1025

merged 1 commit into from
Jun 20, 2019

Conversation

ryalanms
Copy link
Member

@ryalanms ryalanms commented Jun 19, 2019 •
edited
Loading

Fixes DRT failures and #1022. (Fixes #1022.)

@ghost ghost requested review from vatsan-madhavan, rladuca and stevenbrix June 19, 2019 23:39
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jun 19, 2019
@stevenbrix
Copy link
Contributor

I looked back over #919 and it's not immediately obvious how this regression started happening, and why these exact changes are the fix. Can you provide more information on what happened? That way we can all learn and maybe be lucky enough to avoid these issues in the future.

@ryalanms
Copy link
Member Author

Translations in .NET Framework were in different file formats and split across multiple files. .resx does not support the metadata contained in these files. .NET Framework contained strings in the satellite assemblies that were not translated for any language that were used to register key commands. Some of these key commands were translated when we moved to .NET Core causing crashes at runtime due to lookup failures. The original change moves the static strings out of the satellite assemblies to prevent accidental translation.

@ryalanms ryalanms merged commit 3c74b60 into master Jun 20, 2019
@vatsan-madhavan
Copy link
Member

Please hold for review from @rladuca or me.

@vatsan-madhavan vatsan-madhavan deleted the textboxfix branch August 23, 2019 20:11
@ghost ghost locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stevenbrix stevenbrix stevenbrix approved these changes

@vatsan-madhavan vatsan-madhavan Awaiting requested review from vatsan-madhavan

@rladuca rladuca Awaiting requested review from rladuca

Assignees
No one assigned
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TextBox's AcceptsReturn does not work
3 participants
@ryalanms @stevenbrix @vatsan-madhavan