Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert C# Reference Assembly Generation to Use GenAPI #1057

Merged
merged 86 commits into from
Jun 24, 2019
Merged
Changes from 1 commit
Commits
Show all changes
86 commits
Select commit Hold shift + click to select a range
cc88c44
Adding DARC dependency for Microsoft.DotNet.GenAPI and updating
rladuca Jun 12, 2019
1e0eb74
Version updates, adding basic target
rladuca Jun 13, 2019
c73aa9b
Enabling GenAPI to generate sources for all applicable assemblies.
rladuca Jun 14, 2019
b026c00
Adding PBT to GenAPI project list.
rladuca Jun 14, 2019
2e6baf2
Initial build targets for GenAPI and generated reference assembly pro…
rladuca Jun 14, 2019
e54b31c
Reverting to projects explicitly declaring their needed PackageRefere…
rladuca Jun 17, 2019
f39b7b8
Adding additional GenAPI params.
rladuca Jun 17, 2019
b39bdad
Switching to generate the reference assembly project via a task using…
rladuca Jun 18, 2019
22dc686
Adding project exclusions for WIndowsBase
rladuca Jun 18, 2019
1d25a1d
Turning off XLIFF generation for reference assemblies.
rladuca Jun 18, 2019
c0c2175
Removing module initializer injection from PCore-ref
Jun 18, 2019
1368634
Removing CompileDependsOn from PFramework-ref
Jun 18, 2019
047d35c
Removing disabling of default compile items to pickup the generated r…
rladuca Jun 18, 2019
9d6b1c6
Adding global API exclusions file.
rladuca Jun 18, 2019
4084c69
Removing further default excludes.
rladuca Jun 18, 2019
f1a0a01
Adding initial exclusions and NoWarns based on building.
rladuca Jun 18, 2019
6f8cf93
Initial change to manual reference assembly projects.
rladuca Jun 19, 2019
d8de8ee
Modifications to build System.Xaml-ref.
rladuca Jun 19, 2019
ce25fa4
Fixing issues with checks against hand ref assembly property.
rladuca Jun 19, 2019
e5d1c84
Adding UIAutomationTypes reference assembly
rladuca Jun 19, 2019
d317215
Adding reference project for UIAutomationProvider
rladuca Jun 19, 2019
96dd69a
Adding UIAutomationClient ref project
rladuca Jun 19, 2019
8fa8dbe
Removing workaround for WindowsBase GenAPI issue and adding back manu…
rladuca Jun 19, 2019
23d7340
Adding UIAutomationClientSideProviders reference project.
rladuca Jun 19, 2019
61a24bd
Adding System.Windows.Input.Manipulations reference project
rladuca Jun 19, 2019
bece66a
Adding PresentationBuildTasks reference project
rladuca Jun 19, 2019
f7929b4
Adding PresentationCore ref project.
rladuca Jun 20, 2019
e24a1e2
Cleaning up PresentationCore ref assembly and adding exclusion notes.
rladuca Jun 20, 2019
f8f0bfd
Adding security attributes to exclusions
rladuca Jun 20, 2019
35e701f
Fixing exclusion list
rladuca Jun 20, 2019
fd4b700
Fixing exclude param
rladuca Jun 20, 2019
71daa01
Fixing attribute exclusions to match CoreFX.
rladuca Jun 20, 2019
eb250d0
Applying new exclusions to ref assembly code and fixups
rladuca Jun 20, 2019
86e94a4
Cleaning UIA assemblies and updating code with latest exclusions.
rladuca Jun 20, 2019
89b2d03
New exclusions and cleanup
rladuca Jun 20, 2019
74e6228
PBT cleanup and new exclusions
rladuca Jun 20, 2019
0100953
New exclusions and fixups for PCore ref assembly
rladuca Jun 20, 2019
0187a32
Adding ReachFramework ref project and cleaning.
rladuca Jun 20, 2019
8408c93
Adding PresentationFramework reference assembly and fixups.
rladuca Jun 21, 2019
9276850
Removing any extraneous ProjectReferences from reference assembly pro…
rladuca Jun 21, 2019
32b69c8
Adding back assembly attributes to ref assemblies where applicable.
rladuca Jun 21, 2019
25e6caf
Removing PBT reference assembly as we're not shipping one anymore.
rladuca Jun 21, 2019
ad86d97
Further removing PBT-ref
rladuca Jun 21, 2019
76073c0
Adding the ReferenceAssemblyAttribute to all hand-crafted ref assembl…
rladuca Jun 21, 2019
6d4dd82
Removing no longer applicable tasks
rladuca Jun 21, 2019
0a018f0
Fixing an issue with incorrect signing of System.Xaml.
rladuca Jun 21, 2019
c17b9d2
Enable ApiCompat against new ref assemblies.
rladuca Jun 21, 2019
c09951e
PresentationFramework ApiCompat baseline
rladuca Jun 21, 2019
9d13de5
ReachFramework ApiCompat baseline
rladuca Jun 21, 2019
c221445
System.Windows.Input.Manipulations ApiCompat baseline
rladuca Jun 21, 2019
fa0a9c7
UIA ApiCompat baselines
rladuca Jun 21, 2019
8a71707
Fixing removal of ObsoleteAttribute and ApiCompat baseline for System…
rladuca Jun 21, 2019
c4fb2be
ApiCompat baselines for WindowsBase
rladuca Jun 21, 2019
c8cd002
Updating WindowsBase ApiCompat baseline.
rladuca Jun 21, 2019
4fe9237
Adding back attributes that were removed incorrectly.
rladuca Jun 21, 2019
0d994d6
Fixing missing attributes
rladuca Jun 21, 2019
ee698b0
Fixing missing attributes on reachframework
rladuca Jun 21, 2019
15472c9
Updating PCore baselines and adding back missing attrs
rladuca Jun 21, 2019
a21c509
PresentationFramework fixup + baselines
rladuca Jun 21, 2019
710c665
Adding missing projects to solution
rladuca Jun 22, 2019
1f1dd57
Fixing ApiCompat bugs
rladuca Jun 22, 2019
308b7d8
Re-baselining with ApiCompat fixes and removing old, no longer applic…
rladuca Jun 22, 2019
10e49db
Adding documentation
rladuca Jun 22, 2019
d27cab9
DARC updates
rladuca Jun 22, 2019
5fb0320
Merge with master
rladuca Jun 22, 2019
e38d686
Updating reference assemblies due to System.Security.Permissions chan…
rladuca Jun 22, 2019
d341fd8
Merge branch 'master' into dev/roladuca/genapics
rladuca Jun 22, 2019
d7d623c
Fixing up ResolveMicrosoftDotNetWpfGitHubReferences so that dotnet_wp…
rladuca Jun 22, 2019
43d56c3
Merge branch 'dev/roladuca/genapics' of https://www.github.com/dotnet…
rladuca Jun 22, 2019
f7ace71
Fixing up ApiCompat for C++\CLI vs C# runtime projects.
rladuca Jun 22, 2019
4253b8a
Fixing PackageRefernece for RID specific MicrosoftDotNetWpfGitHubPack…
rladuca Jun 22, 2019
3c6de1f
Adding back ensure directory targets for GenAPI
rladuca Jun 22, 2019
2de70d4
Merge branch 'master' into dev/roladuca/genapics
rladuca Jun 22, 2019
20e5f89
Adding dotnet-wpf-int ref assemblies to signing and apicompat.
rladuca Jun 22, 2019
cf1502c
Merge branch 'dev/roladuca/genapics' of https://www.github.com/dotnet…
rladuca Jun 22, 2019
12c99da
Cleaning up reference assembly generation.
rladuca Jun 22, 2019
3f59366
Adding back some internals to satisfy XAML compilation.
rladuca Jun 23, 2019
5da7b0c
Add back internals to support XAML compilation.
rladuca Jun 23, 2019
4552662
DARC Updates
rladuca Jun 23, 2019
fd71569
Documentation fixups.
rladuca Jun 23, 2019
67f70a1
Merge branch 'master' into dev/roladuca/genapics
rladuca Jun 23, 2019
6ed400a
Documentation updates
rladuca Jun 23, 2019
b554672
Fixing mistake in doc link.
rladuca Jun 23, 2019
c8fdf22
More doc fixes
rladuca Jun 23, 2019
dd36d65
DARC Updates
rladuca Jun 24, 2019
9ba4f4c
Merge branch 'master' into dev/roladuca/genapics
rladuca Jun 24, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adding dotnet-wpf-int ref assemblies to signing and apicompat.
rladuca committed Jun 22, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 20e5f89be274cf8c4cc7f010b751c777037f3ed8
28 changes: 19 additions & 9 deletions eng/WpfArcadeSdk/tools/ApiCompat.props
Original file line number Diff line number Diff line change
@@ -9,24 +9,24 @@
PresentationBuildTasks;
PresentationCore-ref;
PresentationFramework-ref;
PresentationFramework.Aero;
PresentationFramework.Aero2;
PresentationFramework.AeroLite;
PresentationFramework.Classic;
PresentationFramework.Luna;
PresentationFramework.Royale;
PresentationFramework.Aero-ref;
PresentationFramework.Aero2-ref;
PresentationFramework.AeroLite-ref;
PresentationFramework.Classic-ref;
PresentationFramework.Luna-ref;
PresentationFramework.Royale-ref;
ReachFramework-ref;
UIAutomationClient-ref;
UIAutomationClientSideProviders-ref;
UIAutomationProvider-ref;
UIAutomationTypes-ref;
System.Printing-ref;
System.Windows.Controls.Ribbon;
System.Windows.Controls.Ribbon-ref;
System.Windows.Input.Manipulations-ref;
System.Windows.Presentation;
System.Windows.Presentation-ref;
System.Xaml-ref;
WindowsBase-ref;
WindowsFormsIntegration;
WindowsFormsIntegration-ref;
</Net48CompatNeededProjects>

<!--
@@ -35,21 +35,31 @@
-->
<Net48RefAssembliesDir>$(RepositoryToolsDir)native\bin\net-framework-48-ref-assemblies\$(NetFramework48RefAssembliesVersion)\</Net48RefAssembliesDir>

<!-- Ignore anything we explicitly told GenAPI to remove from reference assemblies. -->
<ApiCompatExcludeAttributeList>$(WpfArcadeSdkRoot)tools\GenApi\GlobalAttrExclusions.txt</ApiCompatExcludeAttributeList>

<!-- These assemblies need to be compared against their hand-crafted reference assemblies. -->
<RefApiCompatNeededProjects>
PresentationCore;
PresentationFramework;
PresentationFramework.Aero;
PresentationFramework.Aero2;
PresentationFramework.AeroLite;
PresentationFramework.Classic;
PresentationFramework.Luna;
PresentationFramework.Royale;
ReachFramework;
UIAutomationClient;
UIAutomationClientSideProviders;
UIAutomationProvider;
UIAutomationTypes;
System.Printing;
System.Windows.Controls.Ribbon;
System.Windows.Input.Manipulations;
System.Windows.Presentation;
System.Xaml;
WindowsBase;
WindowsFormsIntegration;
</RefApiCompatNeededProjects>

<!-- TODO:
16 changes: 16 additions & 0 deletions eng/WpfArcadeSdk/tools/ShippingProjects.props
Original file line number Diff line number Diff line change
@@ -85,7 +85,16 @@
</ExternalHandCraftedReferenceProjects>

<InternalHandCraftedReferenceProjects>
PresentationFramework.Aero-ref;
PresentationFramework.Aero2-ref;
PresentationFramework.AeroLite-ref;
PresentationFramework.Classic-ref;
PresentationFramework.Luna-ref;
PresentationFramework.Royale-ref;
System.Printing-ref;
System.Windows.Controls.Ribbon-ref;
System.Windows.Presentation-ref;
WindowsFormsIntegration-ref;
</InternalHandCraftedReferenceProjects>

<HelperProjects>
@@ -105,11 +114,17 @@
PresentationFramework;
PresentationFramework-ref;
PresentationFramework.Aero;
PresentationFramework.Aero-ref;
PresentationFramework.Aero2;
PresentationFramework.Aero2-ref;
PresentationFramework.AeroLite;
PresentationFramework.AeroLite-ref;
PresentationFramework.Classic;
PresentationFramework.Classic-ref;
PresentationFramework.Luna;
PresentationFramework.Luna-ref;
PresentationFramework.Royale;
PresentationFramework.Royale-ref;
PresentationUI;
ReachFramework;
ReachFramework-ref;
@@ -126,6 +141,7 @@
WindowsBase;
WindowsBase-ref;
WindowsFormsIntegration;
WindowsFormsIntegration-ref;
PresentationFramework-PresentationUI-api-cycle;
PresentationFramework-ReachFramework-impl-cycle;
PresentationFramework-System.Printing-api-cycle;