Skip to content

Define _WindowsDesktopSdkTargetFrameworkVersionFloor before Microsoft.NET.Sdk.WindowsDesktop.targets is imported #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2019
Merged

Define _WindowsDesktopSdkTargetFrameworkVersionFloor before Microsoft.NET.Sdk.WindowsDesktop.targets is imported #1077

merged 2 commits into from
Jun 24, 2019

Conversation

vatsan-madhavan
Copy link
Member

Define _WindowsDesktopSdkTargetFrameworkVersionFloor before Microsoft.NET.Sdk.WindowsDesktop.targets is imported

This is needed since we changed the way props are defined in #1027

@ghost ghost requested review from rladuca, ryalanms and stevenbrix June 24, 2019 20:57
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jun 24, 2019
@vatsan-madhavan vatsan-madhavan added this to the Preview milestone Jun 24, 2019
@vatsan-madhavan vatsan-madhavan self-assigned this Jun 24, 2019
@vatsan-madhavan vatsan-madhavan force-pushed the dev/vatsan/internal-pbt-fixup branch from 0cde30d to f0c4277 Compare June 24, 2019 21:03
@vatsan-madhavan vatsan-madhavan added the auto_merge bot-command label Jun 24, 2019
@ghost
Copy link

ghost commented Jun 24, 2019

Hello @vatsan-madhavan!

Because this pull request has the auto_merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 30 minutes, a condition that will be fulfilled in about 19 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Jun 24, 2019

@msftbot, require at least 1 sign off.

@ghost
Copy link

ghost commented Jun 24, 2019

@msftbot, require approvals from any one of the following: @vatsan-madhavan, @rladuca, @SamBent, @stevenbrix, @ryalanms

@vatsan-madhavan vatsan-madhavan merged commit 0e65a17 into master Jun 24, 2019
@vatsan-madhavan vatsan-madhavan deleted the dev/vatsan/internal-pbt-fixup branch June 24, 2019 23:27
@vatsan-madhavan
Copy link
Member Author

Having trouble completing PR builds in < 60 mins due to Helix machine acquisition issues. The build otherwise passes cleanly. Forcing the PR to merge to unblock others in the team.

@vatsan-madhavan vatsan-madhavan mentioned this pull request Jun 24, 2019
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rladuca rladuca rladuca approved these changes

@ryalanms ryalanms ryalanms approved these changes

@stevenbrix stevenbrix Awaiting requested review from stevenbrix

Assignees

@vatsan-madhavan vatsan-madhavan

Labels
auto_merge bot-command PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
Preview
Development

Successfully merging this pull request may close these issues.
3 participants
@vatsan-madhavan @rladuca @ryalanms