Remove always-true condition

[Youssef1313]

No description provided.

[lindexi]

NullReferenceException?

Could you use string.IsNullOrEmpty ?

[Youssef1313]

The caller code is:

                string fullName = ((string)source).Trim();
                object key = GetKey(fullName, CultureInfo.InvariantCulture);

Trim won't return null, so fullName is going to be a non-null value.

[Youssef1313]

If you looked at the old code and traced it if the passed keyToken is null, You'll find that it will throw NullReferenceException at:

                keyToken = keyToken.ToUpper(culture);

But, anyway the passed value isn't null. So, it's okay.

[lindexi]

Thank you @Youssef1313

And I think the if (keyToken.Length == 0) code doesn't match the subject. Your subject is Remove always-true condition but this code is to improve performance.

[Youssef1313]

Your subject is Remove always-true condition but this code is to improve performance.

That's correct. I just did both because they're in the same file and the change is really small.

[ryalanms]

Thanks, @Youssef1313.