Remove custom copy of PtrToStringChars #3117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
requested review from
ryalanms
added
the
Priority:1
ryalanms
approved these changes
Jan 7, 2021
fabiant3
reviewed
Jan 7, 2021
There was a problem hiding this comment.
There should be no more instances of our custom implementation now, given wpfvcclr.h is also being deleted. We have yet to enable our test collateral to be run in the open, but this looks safe. Thanks for the PR @GrabYourPitchforks!
fabiant3
approved these changes
Jan 7, 2021
This was referenced Jan 11, 2021
|
Thank you for your contribution, @GrabYourPitchforks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes WPF's custom implementation of
PtrToStringCharsin favor of the built-in version. The custom version was originally introduced to work around CAS performance issues. However, since Core did not bring any of the CAS infrastructure forward, there's no need for the custom copy.Related: dotnet/runtime#31406