Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clearer win32 exception information in SplashScreen CreateWindow #3923

Merged

Conversation

lindexi
Copy link
Member

@lindexi lindexi commented Dec 20, 2020

No description provided.

@lindexi lindexi requested a review from a team as a code owner December 20, 2020 09:42
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Dec 20, 2020
@ghost ghost requested review from fabiant3, ryalanms and SamBent December 20, 2020 09:42
@lindexi lindexi changed the title Add clearer win32 exception information Add clearer win32 exception information in SplashScreen CreateWindow Dec 20, 2020
@ryalanms
Copy link
Member

ryalanms commented Jan 4, 2021

Thanks, @lindexi.

@ryalanms ryalanms merged commit 7c477e8 into dotnet:master Jan 4, 2021
@lindexi lindexi deleted the t/lindexi/SplashScreenCreateWindow branch April 24, 2021 01:44
@lindexi
Copy link
Member Author

lindexi commented Oct 18, 2021

Sorry, this pr is not needed. Because the Win32Exception will get the LastErrorCode when we create it without set the code.

    public Win32Exception()
      : this(Marshal.GetLastWin32Error())
    {
    }

@ghost ghost locked as resolved and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants