[release/5.0] Improve handling of custom paths in markup compiler #4009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
requested review from
|
/cc @clairernovotny |
|
Fixes #3989. |
|
Thanks, @mmitche. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[release/5.0] Improve handling of custom paths in markup compiler [ask-mode for 5.0 servicing]
This feature requires applications to opt-in by explicitly setting a property in their project file. Otherwise, the existing path handling code is executed.
This PR brings the changes from master to release/5.0:
A single property turns on the feature
(IncludePackageReferencesDuringMarkupCompilation = true)and enables the new behavior. By default, the unmodified markup compiler code is called, the old path.