Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused local variable 'selfStyle' and related conditionals in System.Windows.StyleHelper.GetThemeStyle #4010

Merged
merged 1 commit into from
Jan 16, 2021
Merged

Remove unused local variable 'selfStyle' and related conditionals in System.Windows.StyleHelper.GetThemeStyle #4010

merged 1 commit into from
Jan 16, 2021

Conversation

lindexi
Copy link
Member

@lindexi lindexi commented Jan 15, 2021

We define the selfStyle variable, but we do not use it. I remove the codes to improve performance

@lindexi
Remove the unuse code.
01a2822 
We define the selfStyle variable, but we do not use it. I remove the codes to improve performance
@lindexi lindexi requested a review from a team as a code owner January 15, 2021 00:49
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jan 15, 2021
@ghost ghost requested review from fabiant3, ryalanms and SamBent January 15, 2021 00:49
ryalanms
ryalanms reviewed Jan 16, 2021
View reviewed changes
Copy link
Member

@ryalanms ryalanms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed this local variable is unused in GetThemeStyle. LGTM.

@ryalanms
Copy link
Member

Thanks, @lindexi. I will update the PR title to something more specific and merge.

@ryalanms ryalanms changed the title Remove the unuse code. Remove unused local variable 'selfStyle' and related conditionals in System.Windows.StyleHelper.GetThemeStyle Jan 16, 2021
@lindexi
Copy link
Member Author

lindexi commented Jan 16, 2021

@ryalanms Thank you. Happy weekend

@ryalanms ryalanms self-requested a review January 16, 2021 04:46
@ryalanms ryalanms merged commit df559cc into dotnet:master Jan 16, 2021
@lindexi lindexi deleted the t/lindexi/StyleHelper branch January 16, 2021 04:50
@predavid predavid mentioned this pull request Jan 21, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryalanms ryalanms ryalanms approved these changes

@fabiant3 fabiant3 Awaiting requested review from fabiant3

@SamBent SamBent Awaiting requested review from SamBent

Assignees
No one assigned
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lindexi @ryalanms