Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port release/5.0 5.0.3 servicing fix to master: markup compiler updates #4038

Merged
merged 3 commits into from
Jan 20, 2021

Conversation

ryalanms
Copy link
Member

[release/5.0] Improve handling of custom paths in markup compiler [ask-mode for 5.0 servicing]

This feature requires applications to opt-in by explicitly setting a property in their project file. Otherwise, the existing path handling code is executed.

This PR brings the changes from master to release/5.0:

A single property turns on the feature (IncludePackageReferencesDuringMarkupCompilation = true) and enables the new behavior. By default, the unmodified markup compiler code is called, the old path.

@ryalanms ryalanms requested a review from a team as a code owner January 20, 2021 19:07
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jan 20, 2021
@ghost ghost requested review from fabiant3 and SamBent January 20, 2021 19:07
@ryalanms ryalanms merged commit 0f7b4e5 into master Jan 20, 2021
@ryalanms ryalanms deleted the merge.release.5.0 branch January 20, 2021 19:43
@ghost ghost locked as resolved and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant