WPF support for ARM64: Enable build in public repo and update packaging #4048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alexandre Zollinger Chohfi <alzollin@microsoft.com> Co-authored-by: Marcpems <marcpe@microsoft.com> Co-authored-by: Juan Sebastian Hoyos Ayala <juhoyosa@microsoft.com> Co-authored-by: Ryland <41491307+ryalanms@users.noreply.github.com>
ghost
requested review from
|
Any reason not to include the packaging + pipeline changes here? |
|
We could combine them, I suppose. |
ryalanms
changed the title
ryalanms
changed the title
Co-authored-by: Alexandre Zollinger Chohfi <alzollin@microsoft.com> Co-authored-by: Marcpems <marcpe@microsoft.com> Co-authored-by: Juan Sebastian Hoyos Ayala <juhoyosa@microsoft.com> Co-authored-by: Ryland <41491307+ryalanms@users.noreply.github.com>
hoyosjs
approved these changes
Jan 21, 2021
|
This PR build check will not pass until the other dependent PRs are merged. |
azchohfi
suggested changes
Jan 21, 2021
Co-authored-by: Alexandre Zollinger Chohfi <alzollin@microsoft.com> Co-authored-by: Marcpems <marcpe@microsoft.com> Co-authored-by: Juan Sebastian Hoyos Ayala <juhoyosa@microsoft.com> Co-authored-by: Ryland <41491307+ryalanms@users.noreply.github.com>
azchohfi
approved these changes
Jan 21, 2021
10 tasks
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
There are failures in our APICompat checks. Investigating... |
Co-authored-by: Alexandre Zollinger Chohfi <alzollin@microsoft.com> Co-authored-by: Marcpems <marcpe@microsoft.com> Co-authored-by: Juan Sebastian Hoyos Ayala <juhoyosa@microsoft.com> Co-authored-by: Ryland <41491307+ryalanms@users.noreply.github.com>
ryalanms
added a commit
that referenced
this pull request
May 7, 2021
…ng (#4048) * WPF support for ARM64: WPF ARM64 public repo Packaging updates * Enable arm64 builds on public WPF repo * Update APICompat targets to work with ARM64 Co-authored-by: Alexandre Zollinger Chohfi <alzollin@microsoft.com> Co-authored-by: Marcpems <marcpe@microsoft.com> Co-authored-by: Juan Sebastian Hoyos Ayala <juhoyosa@microsoft.com> Co-authored-by: Ryland <41491307+ryalanms@users.noreply.github.com>
ryalanms
added a commit
that referenced
this pull request
May 17, 2021
…ng (#4048) * WPF support for ARM64: WPF ARM64 public repo Packaging updates * Enable arm64 builds on public WPF repo * Update APICompat targets to work with ARM64 Co-authored-by: Alexandre Zollinger Chohfi <alzollin@microsoft.com> Co-authored-by: Marcpems <marcpe@microsoft.com> Co-authored-by: Juan Sebastian Hoyos Ayala <juhoyosa@microsoft.com> Co-authored-by: Ryland <41491307+ryalanms@users.noreply.github.com>
ryalanms
added a commit
that referenced
this pull request
Jun 12, 2021
… updates (#4523) Port WPF ARM64 support to NET 5: Final project, source, and packaging updates (#4523). * [release/5.0] Update dependencies from dnceng/internal/dotnet-wpf-int (#4381) * [release/5.0] Update dependencies from dnceng/internal/dotnet-wpf-int * Update release/5.0 branding to 5.0.6 (#4380) * Update dependencies from https://github.com/dotnet/arcade build 20210310.3 (#4401) * [release/5.0] Update dependencies from dotnet/arcade * [internal/release/5.0] Update dependencies from dnceng/internal/dotnet-winforms * Update WPF Arcade SDK to support ARM64 * Update source files contained in the WPF Arcade SDK for ARM64 * Use correct TFM. TFM should be win-arm64, not win10-arm64. * Update WPF repo TFM from netcoreapp5.0 to net5.0 * Update Wpf.Cpp.Targets TFM. Win10- should be win-. (#4046) Update Wpf.Cpp.Targets TFM. Win10- should be win-. (#4046) * WPF support for ARM64: WPF public repo project updates and final source fixes (#4049) * WPF support for ARM64: WPF public repo project updates and final source fixes * Add Juan's sln fix for ARM64 platform * WPF support for ARM64: Enable build in public repo and update packaging (#4048) * WPF support for ARM64: WPF ARM64 public repo Packaging updates * Enable arm64 builds on public WPF repo * Update APICompat targets to work with ARM64 Co-authored-by: Alexandre Zollinger Chohfi <...> Co-authored-by: Marcpems <...> Co-authored-by: Juan Sebastian Hoyos Ayala <...> Co-authored-by: Ryland <41491307+ryalanms@users.noreply.github.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete any remaining packaging and pipeline updates and enable ARM64 builds in the WPF repo.
Requires #4034, #4035, #4041, and #4042 to be completed beforehand.
Co-authored-by: Alexandre Zollinger Chohfi <...>
Co-authored-by: Marcpems <...>
Co-authored-by: Juan Sebastian Hoyos Ayala <...>
Co-authored-by: Ryland 41491307+ryalanms@users.noreply.github.com
/cc @azchohfi @hoyosjs @marcpems