Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unuse static field in ImageDrawing.cs #5651

Conversation

lindexi
Copy link
Member

@lindexi lindexi commented Nov 7, 2021

Description

Remove unuse static field in ImageDrawing.cs

Customer Impact

No.

Regression

.NET 7

Testing

Just CI

Risk

Low.

@lindexi lindexi requested a review from a team as a code owner November 7, 2021 09:27
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Nov 7, 2021
@ghost ghost requested review from fabiant3, ryalanms and SamBent November 7, 2021 09:27
RussKie
RussKie previously approved these changes Nov 26, 2021
@ThomasGoulet73
Copy link
Contributor

This file seems to be generated and it says at the top of the file to not edit it manually: https://github.com/dotnet/wpf/blob/main/src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Media/Generated/ImageDrawing.cs#L7.

I thinkg that this field is generated from this entry in the xml: https://github.com/dotnet/wpf/blob/main/src/Microsoft.DotNet.Wpf/src/WpfGfx/codegen/mcg/xml/Resource.xml#L3426.

You can try removing the entry in the xml and then running the codegen (I haven't tried running the codegen but you can take a look at the readme). It also generates some C++ code so this field might be used elsewhere.

@vishalmsft
Copy link
Contributor

Thank you @ThomasGoulet73 for highlighting the catch.
Yes for generated code, editing manually is not a good idea. Will take a deeper look at XML and all generated source code.

@RussKie
Copy link
Member

RussKie commented Nov 30, 2021

Haha, I should've paid more attention

//
//
// This file was generated, please do not edit it directly.
//
// Please see MilCodeGen.html for more information.
//

@dipeshmsft
Copy link
Member

@lindexi, Can we go ahead and close this PR ??

@lindexi
Copy link
Member Author

lindexi commented Jan 29, 2022

@dipeshmsft Yes.

@lindexi lindexi closed this Jan 29, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Apr 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants