Run some built-in .NET SDK perf analyzers over several WPF assemblies #6274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
requested review from
...Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Media/Generated/DoubleCollection.cs
Show resolved
Hide resolved
stephentoub
force-pushed
the
analyzercleanup
branch
from
dded74b to
3c3de14
Compare
stephentoub
force-pushed
the
analyzercleanup
branch
from
3c3de14 to
22240c2
Compare
bgrainger
reviewed
May 30, 2022
src/Microsoft.DotNet.Wpf/src/PresentationCore/MS/internal/IO/Packaging/ByteRangeDownloader.cs
Show resolved
Hide resolved
dipeshmsft
approved these changes
Jul 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Over the last several releases of .NET, the SDK has added a multitude of analyzers to help find and flag opportunities for perf improvements. I ran several of those analyzers over a few of the assemblies and applied the auto-fixers; I also code reviewed each fix and tweaked a handfull.
Customer Impact
Many of these changes contribute small but meaningful reductions in overhead.
Regression
No
Testing
CI
Risk
Minimal