RuntimeFrameworkVersion enablement - final step (test projects) #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oft.DotNet.Wpf.DncEng chains correctly to the corresponding RID-specific package.
rladuca
approved these changes
May 20, 2019
Update path to native DLL's
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final change that brings tests into the fold of building using
RuntimeFrameworkVersion.This completes the work that we started at the end of Preview 4 to to use
RuntimeFrameworkVersionto build the product bits (#534, #604) in order to improve the coherent-build process for core-sdk. Tests could not be enabled at that time because Arcade SDK lacked the capability to install multiple side-by-side SDK's (an extra version corresponding to$(MicrosoftNETCoreAppVersion)(defined ineng\Versions.props), needed to run tests since they would build against that version ofMicrosoft.NetCore.App).This missing functionality has since been enabled by dotnet/arcade#2343 and dotnet/arcade#2815; along with these, #703 helps fix a prerequisite problem. Taken together, we are now able to build the entire repo using
RuntimeFrameworkVersionagainst$(MicrosoftNETCoreAppVersion)version ofMicrosoft.NETCore.App