Simplify CriticalCopyPixels in BitmapSource by removing duplicate type checks #9395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
PR
h3xds1nz
changed the title
h3xds1nz
force-pushed
the
bitmap-src-simplify-pinning
branch
from
01ead7b to
ff111c1
Compare
|
Resolved merge conflicts 06 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes redundant type checks second-time around when copying pixels in
CriticalCopyPixels. There's a small performance improvement, however, the main goal here is decreasing code size, and also code simplification that has been made possible with the introduction ofGetArrayDataReferencefew releases ago.Since
Unsafe.AddByteOffsetwon't do an index-out-of-bounds check for us, we do it ourselves to keep the same behaviour as previously, throwingIndexOutOfRangeExceptionon whenoffsetexceeds the array length.Customer Impact
Smaller code-size of PresentationCore.
Regression
No.
Testing
Local build.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow