Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify AvTrace call chain to use params ReadOnlySpan<object> instead of an array #9468

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

h3xds1nz
Copy link
Contributor

@h3xds1nz h3xds1nz commented Jul 25, 2024

Fixes #9467 Reference #9463

Description

More of a complex fix, modifies the call chain to make use of the latest .NET features.

Customer Impact

Improved performance when tracing is active, decreased array allocations per each executed trace, smaller assemblies due to the function removal.

Regression

Fixes the ref held by _traceArguments from #6700

Testing

Local build, app run with tracing, comparing outputs of release/PR.

Risk

Low, the actual change is small and was reviewed/tested.

Microsoft Reviewers: Open in CodeFlow

@h3xds1nz h3xds1nz requested review from a team as code owners July 25, 2024 17:21
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Jul 25, 2024
@h3xds1nz h3xds1nz changed the title Modify EventRoute/TraceData call chain to use params Span<object> instead of an array Modify AvTrace call chain to use params Span<object> instead of an array Jul 25, 2024
@h3xds1nz h3xds1nz changed the title Modify AvTrace call chain to use params Span<object> instead of an array Modify AvTrace call chain to use params ReadOnlySpan<object> instead of an array Jul 26, 2024
@Alexgoon
Copy link

Alexgoon commented Aug 8, 2024

Hi there! Could you please update us on the status of this pull request? It's important for DevExpress components, and we're eager to know if you plan to merge it.

@h3xds1nz
Copy link
Contributor Author

h3xds1nz commented Aug 8, 2024

Hey @Alexgoon, I'm gonna CC a few guys from the wpf team just to be sure it doesn't get lost.

cc @pchaurasia14 @dipeshmsft

@Alexgoon
Copy link

Hi again,
I see the merging process has started - thanks for that! However, it looks like it’s stalled. Could you let me know if you plan to include this PR in the upcoming .NET 9 release?

@pchaurasia14
Copy link
Member

@Alexgoon - We will be including this PR for upcoming test cycles, and it will go in for .NET 10.

@Alexgoon
Copy link

@pchaurasia14, thanks for the clarification! We were hoping the PR would be merged into .NET 9 since it addresses the issue described in #9467, which surfaced in .NET 9. After migrating to the latest version, a lot of our memory-related tests started failing.

I also noticed another PR (#9463) that might help resolve the memory leak issue. Do you have any plans to merge it into .NET 9, or will the memory issue (#9467) be handled as part of another fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution A label for all community Contributions Included in test pass PR metadata: Label to tag PRs, to facilitate with triage Status:Completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WPF control is not reclaimed on NET9 by GC
8 participants