Replace SecurityHelper.AreStringTypesEqual with string.Equals for code quality #9521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
PR
|
I think the |
|
Yes, it would be inlined, of course. The reason for this is purely code quality. There should be no It only complicates the code readibility with another level of indirection. Oh, look, "AreStringTypesEqual"... but it is CI compare! |
Yeah, I fully agree. |
dipeshmsft
approved these changes
Oct 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One of the few leftover remnants from CAS times is the
SecurityHelper.AreStringTypesEqualthat just calls case-insensitivestring.Equals. There is no reason for this method as it has even lost the original comment throughout the removals and just makes newcomers wonder why is it there.Customer Impact
Few bytes less in size of all libraries.
Regression
No.
Testing
Local build.
Risk
None.
Microsoft Reviewers: Open in CodeFlow