Address https://github.com/dotnet/runtime/issues/45428 #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all cache is full or something, rebooting device helps. Also improve wait-for-device to actually check the boot_completed prop
akoeplinger
approved these changes
Dec 2, 2020
|
The macOS helix queues were a little busy but both of the jobs actually succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a mystery state where the install cache is full or something, rebooting device helps.
Also improve wait-for-device to actually check the boot_completed property (exposed by rebooting devices) and fix standard error logging bug pointed out by @akoeplinger that's been there forever.
Since the state is mysterious, I prototyped an "always reboot the device" version of Xharness and ran it several times Sample log to be sure the concept here works (logging has been cleaned up a bit)