Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename X-Forwarded-PathBase to X-Forwarded-Prefix #737

Closed
Tratcher opened this issue Feb 11, 2021 · 4 comments · Fixed by #897
Closed

Rename X-Forwarded-PathBase to X-Forwarded-Prefix #737

Tratcher opened this issue Feb 11, 2021 · 4 comments · Fixed by #897
Labels
help wanted We will welcome a contribution Type: Bug Something isn't working
Milestone

Comments

@Tratcher
Copy link
Member

Follow up to #225 and #13.

Per some user provided research here, X-Forwarded-Prefix is the more common name for this header.

/cc: @damianh

@Tratcher Tratcher added the Type: Bug Something isn't working label Feb 11, 2021
@damianh
Copy link

damianh commented Feb 13, 2021

Interesting...thx for cc. Searching up on this and most of the X-Forward-Prefix content (SO questions, docs in various proxies etc) seems to be a recent thing (last couple of years). I've reckon I've been using X-Forward-PathBase for nearly a decade... 🤷‍♂️

Since a variety reverse proxy implementations are converging on X-Forward-Prefix I agree that renaming is reasonable.

On a related item, will Microsoft.AspNetCore.HttpOverrides also be updated to use this header? If so, I could kill off this project :)

@Tratcher
Copy link
Member Author

On a related item, will Microsoft.AspNetCore.HttpOverrides also be updated to use this header?

dotnet/aspnetcore#23263 tracks that.

@karelz
Copy link
Member

karelz commented Mar 22, 2021

Triage: There is de facto standard for this (see dotnet/aspnetcore#23263 (comment)), we should implement it.

@karelz karelz added this to the YARP 1.0.0 milestone Mar 22, 2021
@karelz karelz added the help wanted We will welcome a contribution label Mar 22, 2021
@karelz
Copy link
Member

karelz commented Mar 22, 2021

Should be fairly simple - anyone interested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted We will welcome a contribution Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants