Conversation
WeihanLi
reviewed
Mar 9, 2024
|
|
||
| <ItemGroup> | ||
| <None Include="README.md" Pack="true" PackagePath="\" /> | ||
| <None Include="..\..\assets\icon.png" PackagePath="icon.png" Pack="true" /> |
Contributor
There was a problem hiding this comment.
Think maybe we could define it in Directory.Build.props to avoid duplicate code, as all packages would need this
https://github.com/microsoft/reverse-proxy/blob/main/src/Directory.Build.props
MihaZupan
approved these changes
Mar 12, 2024
Member
MihaZupan
left a comment
MihaZupan
left a comment
There was a problem hiding this comment.
Thanks.
Mind adding it to the Yarp.Kubernetes.Controller.csproj package as well (not shipping yet)? Or include it in Directory.Build.props if possible
Member
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
MihaZupan
added
the
Type: Documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now has an icon!
