Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs vs spaces #122

Closed
craigktreasure opened this issue Dec 27, 2022 · 3 comments · Fixed by #153
Closed

Tabs vs spaces #122

craigktreasure opened this issue Dec 27, 2022 · 3 comments · Fixed by #153
Labels
good first issue Good for newcomers

Comments

@craigktreasure
Copy link

Not a deal breaker and more of a nitpick, but the dotnet-config tool appears to use tabs for indentation as opposed to spaces. This was a bit unexpected for me. Git uses and prefers spaces in a .gitconfig file. Curious if there is a reason for using tabs over spaces other than preference.

@kzu
Copy link
Collaborator

kzu commented Jul 3, 2023

Yeah, no particular reason, just preference.

@kzu kzu added the question Further information is requested label Jul 3, 2023
@kzu
Copy link
Collaborator

kzu commented Jun 25, 2024

Given that git uses spaces in .gitconfig, perhaps we should switch to that too, in the spirit of standardization at least...

@kzu kzu added good first issue Good for newcomers and removed question Further information is requested labels Jun 25, 2024
@kzu
Copy link
Collaborator

kzu commented Jun 25, 2024

I actually just run the following command:

git config -f .netconfig.git foo.bar baz

and the file ended up with a tab before the variable:

[foo]
	bar = baz

So I'd say we're 100% compatible :)

@kzu kzu closed this as completed Jun 25, 2024
kzu added a commit that referenced this issue Jun 25, 2024
To ensure compatibility with git config.

Closes #122
kzu added a commit that referenced this issue Jun 25, 2024
To ensure compatibility with git config.

Closes #122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants