fix(MenuLink): always active if href equal "/" #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solutions as per dotnet/aspnetcore#9156 <NavLink href="/" Match=NavLinkMatch.All>Home</NavLink>
|
Thanks for your PR, @ray-gilbert. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
|
ArgoZhang
approved these changes
Sep 29, 2023
ArgoZhang
changed the title
ArgoZhang
changed the title
|
@ray-gilbert thank you for submitting PR for this project. could you give this project a star if you like this repo |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2204 +/- ##
===========================================
- Coverage 100.00% 99.98% -0.02%
===========================================
Files 522 522
Lines 16963 17004 +41
===========================================
+ Hits 16963 17002 +39
- Misses 0 2 +2
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solutions as per dotnet/aspnetcore#9156 Home
always active if href equal "/"
Description
close #2207