Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Utility): add AddLinkBatch/AddScriptBatch method #2809

Merged
merged 13 commits into from
Jan 16, 2024
Merged

Conversation

h2ls
Copy link
Collaborator

@h2ls h2ls commented Jan 16, 2024

refactor utility module to include batch script and link handling

Description

This PR refactors the utility module to include batch handling for script and link operations. It adds the functions addScriptBatch, removeScriptBatch, addLinkBatch, and removeLinkBatch, providing the ability to manage multiple scripts and links at once. This enhances the utility module's capabilities and improves code efficiency.

close #2808

…LinkBatch, and removeLinkBatch to the utility.js module.
Copy link

bb-auto bot commented Jan 16, 2024

Thanks for your PR, @azlis. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@bb-auto bb-auto bot requested a review from ArgoZhang January 16, 2024 07:01
@bb-auto bb-auto bot added the enhancement New feature or request label Jan 16, 2024
@bb-auto bb-auto bot added this to the v8.1.0 milestone Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46fc042) 100.00% compared to head (c8bdcc6) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2809   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          541       541           
  Lines        23388     23379    -9     
  Branches      3397      3397           
=========================================
- Hits         23388     23379    -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h2ls h2ls marked this pull request as draft January 16, 2024 07:13
@h2ls h2ls marked this pull request as ready for review January 16, 2024 07:23
ArgoZhang
ArgoZhang previously approved these changes Jan 16, 2024
@ArgoZhang ArgoZhang changed the title feat(utility.js): refactor utility module to include batch script and link handling feat(Utility): refactor utility module to include batch script and link handling Jan 16, 2024
@ArgoZhang ArgoZhang changed the title feat(Utility): refactor utility module to include batch script and link handling feat(Utility): add AddLinkBatch/AddScriptBatch method Jan 16, 2024
@ArgoZhang ArgoZhang merged commit 7c16c5d into main Jan 16, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the lee/Utility branch January 16, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(utility.js): refactor utility module to include batch script and link handling
2 participants