Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IpAddress): add support for handling both keyboard and numpad input for numeric values #3095

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

h2ls
Copy link
Collaborator

@h2ls h2ls commented Mar 19, 2024

add support for handling both keyboard and numpad input for numeric values

Description

close #3094

Copy link

bb-auto bot commented Mar 19, 2024

Thanks for your PR, @azlis. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@bb-auto bb-auto bot requested a review from ArgoZhang March 19, 2024 05:55
@bb-auto bb-auto bot added the enhancement New feature or request label Mar 19, 2024
@bb-auto bb-auto bot added this to the v8.3.0 milestone Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (5f1badd) to head (5ecd74f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3095   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files         568      568           
  Lines       24480    24480           
  Branches     3540     3540           
=======================================
  Hits        24471    24471           
  Misses          4        4           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 74d6c45 into main Mar 19, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the lee/ipaddress branch March 19, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(IpAddress): add support for handling both keyboard and numpad input for numeric values
2 participants