Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Dock): not show close button when any tab set ShowClose to false #3307

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

ArgoZhang
Copy link
Collaborator

not show close button when any tab set ShowClose to false

Description

close #3306

@bb-auto bb-auto bot added the enhancement New feature or request label Apr 18, 2024
@bb-auto bb-auto bot added this to the V8.4.0 milestone Apr 18, 2024
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@a44d183). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3307   +/-   ##
=======================================
  Coverage        ?   99.96%           
=======================================
  Files           ?      584           
  Lines           ?    24872           
  Branches        ?     3600           
=======================================
  Hits            ?    24863           
  Misses          ?        4           
  Partials        ?        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 39cea7d into main Apr 18, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the feat-dockview branch April 18, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(Dock): not show close button when any tab set ShowClose to false
1 participant