Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Select): Clear search text while clearing text content #3340

Merged
merged 6 commits into from
Apr 25, 2024

Conversation

h2ls
Copy link
Collaborator

@h2ls h2ls commented Apr 24, 2024

Clear search text while clearing text content

Description

private void OnClearValue()
{
    if (ShowSearch)
    {
        ClearSearchText();
    }
    CurrentValue = default;
}

close #3339

在`Select.razor.cs`文件中,我们对`Select<TValue>`类的`OnClearValue()`方法进行了更新。现在,如果`ShowSearch`为真,我们会调用`ClearSearchText()`方法。这意味着,当清除值时,如果启用了搜索功能,搜索文本也会被清除。
Copy link

bb-auto bot commented Apr 24, 2024

Thanks for your PR, @azlis. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@bb-auto bb-auto bot requested a review from ArgoZhang April 24, 2024 06:28
@bb-auto bb-auto bot added the enhancement New feature or request label Apr 24, 2024
@bb-auto bb-auto bot added this to the V8.4.0 milestone Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.88%. Comparing base (6fb8a14) to head (9ded21f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3340   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files         584      584           
  Lines       24895    24904    +9     
  Branches     3605     3607    +2     
=======================================
+ Hits        24867    24876    +9     
  Misses         20       20           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h2ls h2ls marked this pull request as draft April 24, 2024 08:42
@h2ls h2ls marked this pull request as ready for review April 24, 2024 08:59
@ArgoZhang ArgoZhang merged commit f568292 into main Apr 25, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the lee/ClearSelectSearchText branch April 25, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(Select): Clear search text while clearing text content
2 participants