Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DateTimeRange): add RenderMode parameter #3445

Merged

Conversation

eramosr16
Copy link
Collaborator

@eramosr16 eramosr16 commented May 7, 2024

Datetime Range Render Mode Property

Basically would provide you with a Datetime Range component that would render in two modes:

  • Double panel.
  • Single panel.

Description

RenderMode = Single|Double

close #3446 #3393

Copy link

bb-auto bot commented May 7, 2024

Thanks for your PR, @eramosr16. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@CLAassistant
Copy link

CLAassistant commented May 7, 2024

CLA assistant check
All committers have signed the CLA.

@bb-auto bb-auto bot requested a review from ArgoZhang May 7, 2024 21:30
@ArgoZhang ArgoZhang changed the title Datetime Range render mode feat(DateTimeRange): add RenderMode parameter May 8, 2024
@bb-auto bb-auto bot added the enhancement New feature or request label May 8, 2024
@bb-auto bb-auto bot added this to the v8.5.0 milestone May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 99.96%. Comparing base (af6cbd9) to head (b3e0237).

Files Patch % Lines
...lazor/Components/DateTimeRange/DateTimeRange.razor 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3445   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files         593      593           
  Lines       25080    25088    +8     
  Branches     3636     3637    +1     
=======================================
+ Hits        25071    25079    +8     
  Misses          4        4           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ArgoZhang
ArgoZhang previously approved these changes May 8, 2024
@eramosr16
Copy link
Collaborator Author

I signed the agreement three times since yesterday but for some reason doesn't appear signed here, please advise when you had a chance.

@eramosr16
Copy link
Collaborator Author

Signed and fixed the email issue

@ArgoZhang ArgoZhang merged commit 0869d3e into dotnetcore:main May 10, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(DateTimeRange): add RenderMode parameter
3 participants