feat(Chart): Add a CanvasBackgroundColor parameter #3458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new plugin named `customCanvasBackgroundColor` to `Chart.razor.js` that allows setting a custom background color for the chart canvas. The `chartOption` object and `getChartOption` function were updated to include this new plugin. Also, a new property `CanvasBackgroundColor` was added to the `ChartOptions` class in `ChartOptions.cs` to get or set the background color of the chart canvas.
|
Thanks for your PR, @azlis. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3458 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 593 593
Lines 25080 25080
Branches 3636 3636
=======================================
Hits 25071 25071
Misses 4 4
Partials 5 5 ☔ View full report in Codecov by Sentry. |
ArgoZhang
previously approved these changes
May 9, 2024
ArgoZhang
previously approved these changes
May 9, 2024
ArgoZhang
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a CanvasBackgroundColor parameter
Description
Added a new plugin named
customCanvasBackgroundColortoChart.razor.jsthat allows setting a custom background color for the chart canvas. ThechartOptionobject andgetChartOptionfunction were updated to include this new plugin. Also, a new propertyCanvasBackgroundColorwas added to theChartOptionsclass inChartOptions.csto get or set the background color of the chart canvas.close #3457