feat(Select): auto append the close icon when using DisplayTemplate #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR, @eramosr16. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
ArgoZhang
approved these changes
May 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3544 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 570 570
Lines 24871 24871
Branches 3625 3625
=======================================
Hits 24870 24870
Partials 1 1 ☔ View full report in Codecov by Sentry. |
ArgoZhang
changed the title
|
@eramosr16 bump version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render select icon regardless template
Dropdown icon disappear when a DisplayTemplate is added to the component, this shouldn't happen.
Description
close #3551