Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Layout): can't collapse side when set side with value #3977

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

SamXMG
Copy link
Contributor

@SamXMG SamXMG commented Aug 5, 2024

can't collapse side when set side with value

close #3981

Copy link

bb-auto bot commented Aug 5, 2024

Thanks for your PR, @SamXMG. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@CLAassistant
Copy link

CLAassistant commented Aug 5, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ArgoZhang
❌ SamXMG


SamXMG seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bb-auto bb-auto bot requested a review from ArgoZhang August 5, 2024 07:48
@ArgoZhang
Copy link
Collaborator

@SamXMG 感谢提交 PR 签署一下 CLA

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e2c60b7) to head (87c4b7c).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #3977   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          593       593           
  Lines        25820     25820           
  Branches      3756      3756           
=========================================
  Hits         25820     25820           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bb-auto bb-auto bot added the bug Something isn't working label Aug 5, 2024
@bb-auto bb-auto bot added this to the v8.8.0 milestone Aug 5, 2024
@ArgoZhang ArgoZhang changed the title 修复Layput设置SideWidth后无法折叠的问题 fix(Layout): can't collapse side when set side with value Aug 5, 2024
@ArgoZhang ArgoZhang merged commit 656c028 into dotnetcore:main Aug 5, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(Layout): can't collapse side when set sidewith value
3 participants