-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ContextMenu): Add OnClickBefore callback event #4112
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your PR, @azlis. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
ArgoZhang
previously approved these changes
Aug 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4112 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 597 598 +1
Lines 25941 25981 +40
Branches 3778 3784 +6
=========================================
+ Hits 25941 25981 +40 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add OnClickBefore callback event
Description
I would like to propose a new feature for the
ContextMenu
component: anOnClickBefore
callback event. This event should be triggered right before the context menu is displayed when the user right-clicks. It would allow developers to perform actions or checks before the menu is rendered to the user.Use Case
The
OnClickBefore
event would be extremely useful for dynamic context menu content, where menu items need to be determined based on the state of the application or specific conditions at the time of the right-click. For example, it could be used to enable or disable menu items, add new ones, or even cancel the display of the context menu altogether based on certain criteria.Proposed Signature
close #4111