Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Table): add EditDialog parameter #4128

Merged
merged 4 commits into from
Aug 25, 2024
Merged

Conversation

vickyhcq
Copy link
Contributor

@vickyhcq vickyhcq commented Aug 23, 2024

Popup 弹窗编辑时候, 可以自定义基于哪个Dialog弹出来, 解决Table如果放在弹出的Dialog, 再弹出EditForm 会导致Table所在的Editform消失的问题

close #4149

Copy link

bb-auto bot commented Aug 23, 2024

Thanks for your PR, @vickyhcq. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@bb-auto bb-auto bot requested a review from ArgoZhang August 23, 2024 02:04
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (61414bb) to head (99c3c59).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4128   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          607       607           
  Lines        26134     26134           
  Branches      3796      3796           
=========================================
  Hits         26134     26134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang
Copy link
Collaborator

@vickyhcq 来个示例工程

ArgoZhang
ArgoZhang previously approved these changes Aug 23, 2024
@ArgoZhang ArgoZhang changed the title add PopupFormDialog Field feat(Table): add EditDialog parameter Aug 25, 2024
@bb-auto bb-auto bot added the enhancement New feature or request label Aug 25, 2024
@bb-auto bb-auto bot added this to the v8.8.0 milestone Aug 25, 2024
@ArgoZhang ArgoZhang merged commit 08141de into dotnetcore:main Aug 25, 2024
5 checks passed
@vickyhcq vickyhcq deleted the Dev-Table2 branch September 3, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(Table): add EditDialog parameter
2 participants