Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DockViewV2): support Renderer parameter #4153

Merged
merged 10 commits into from
Aug 26, 2024
Merged

feat(DockViewV2): support Renderer parameter #4153

merged 10 commits into from
Aug 26, 2024

Conversation

zhaijunlei955
Copy link
Collaborator

@zhaijunlei955 zhaijunlei955 commented Aug 26, 2024

support Renderer parameter

Description

close #4154

Copy link

bb-auto bot commented Aug 26, 2024

Thanks for your PR, @zhaijunlei955. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@bb-auto bb-auto bot requested a review from ArgoZhang August 26, 2024 01:41
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (08141de) to head (0864958).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4153   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          607       607           
  Lines        26134     26134           
  Branches      3796      3796           
=========================================
  Hits         26134     26134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bb-auto bb-auto bot added the enhancement New feature or request label Aug 26, 2024
@bb-auto bb-auto bot added this to the v8.8.0 milestone Aug 26, 2024
ArgoZhang
ArgoZhang previously approved these changes Aug 26, 2024
ArgoZhang
ArgoZhang previously approved these changes Aug 26, 2024
@ArgoZhang ArgoZhang merged commit 5945b0f into main Aug 26, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the fix-dv-renderer branch August 26, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(DockViewV2): add Renderer parameter
2 participants