Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(IValidateComponent): remove ToggleMessage validProperty parameter #4252

Merged
merged 9 commits into from
Sep 10, 2024
Merged

refactor(IValidateComponent): remove ToggleMessage validProperty parameter #4252

merged 9 commits into from
Sep 10, 2024

Conversation

izanhzh
Copy link
Collaborator

@izanhzh izanhzh commented Sep 10, 2024

close #4251

@bb-auto bb-auto
Copy link

bb-auto bot commented Sep 10, 2024

Thanks for your PR, @izanhzh. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@bb-auto bb-auto bot requested a review from ArgoZhang September 10, 2024 05:10
@codecov Codecov
Copy link

codecov bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f118a21) to head (f4e4c30).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #4252   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          611       611           
  Lines        26313     26313           
  Branches      3828      3828           
=========================================
  Hits         26313     26313

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang changed the title feat(IValidateComponent): delete unnecessary parameter refactor(IValidateComponent): remove ToggleMessage validProperty parameter Sep 10, 2024
@ArgoZhang ArgoZhang self-requested a review September 10, 2024 06:22
@ArgoZhang ArgoZhang added the enhancement New feature or request label Sep 10, 2024
@ArgoZhang ArgoZhang added this to the v8.9.0 milestone Sep 10, 2024
ArgoZhang
ArgoZhang previously approved these changes Sep 10, 2024
View reviewed changes
@ArgoZhang ArgoZhang merged commit 0de6cc8 into dotnetcore:main Sep 10, 2024
5 checks passed
@izanhzh izanhzh deleted the feat-validate-base branch September 10, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArgoZhang ArgoZhang ArgoZhang approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v8.9.0
Development

Successfully merging this pull request may close these issues.

refactor(IValidateComponent): remove ToggleMessage validProperty parameter
2 participants
@izanhzh @ArgoZhang