-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ValidateForm): validate all validation from MetadataType #4360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your PR, @AiYuZhen. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4360 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 613 613
Lines 26530 26535 +5
Branches 3870 3871 +1
=========================================
+ Hits 26530 26535 +5 ☔ View full report in Codecov by Sentry. |
# Conflicts: # src/BootstrapBlazor/Components/ValidateForm/ValidateForm.razor.cs
ArgoZhang
previously approved these changes
Sep 26, 2024
ArgoZhang
changed the title
fix(ValidateForm):MetadataType 方式且继承 IValidateCollection 接口后对涉及属性单独验证在特定条件下不显示错误
fix(ValidateForm): validate all validation from MetadataType
Sep 26, 2024
ArgoZhang
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(ValidateForm):MetadataType 方式且继承 IValidateCollection 接口后对涉及属性单独验证在特定条件下不显示错误
MetadataType 方式继承 IValidateCollection 接口验证后又对其中涉及的属性进行了单独验证,在特定情况下会忽略单独验证的错误提示。
fixes #4359
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge