Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ValidateForm): validate all validation from MetadataType #4360

Merged
merged 10 commits into from
Sep 26, 2024

Conversation

AiYuZhen
Copy link
Contributor

@AiYuZhen AiYuZhen commented Sep 26, 2024

fix(ValidateForm):MetadataType 方式且继承 IValidateCollection 接口后对涉及属性单独验证在特定条件下不显示错误

MetadataType 方式继承 IValidateCollection 接口验证后又对其中涉及的属性进行了单独验证,在特定情况下会忽略单独验证的错误提示。

fixes #4359

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Copy link

bb-auto bot commented Sep 26, 2024

Thanks for your PR, @AiYuZhen. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@bb-auto bb-auto bot requested a review from ArgoZhang September 26, 2024 07:05
@bb-auto bb-auto bot added the bug Something isn't working label Sep 26, 2024
@bb-auto bb-auto bot added this to the v8.9.0 milestone Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3cb9837) to head (c5cadad).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4360   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          613       613           
  Lines        26530     26535    +5     
  Branches      3870      3871    +1     
=========================================
+ Hits         26530     26535    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ArgoZhang
ArgoZhang previously approved these changes Sep 26, 2024
@ArgoZhang ArgoZhang changed the title fix(ValidateForm):MetadataType 方式且继承 IValidateCollection 接口后对涉及属性单独验证在特定条件下不显示错误 fix(ValidateForm): validate all validation from MetadataType Sep 26, 2024
@ArgoZhang ArgoZhang enabled auto-merge (squash) September 26, 2024 14:54
@ArgoZhang ArgoZhang merged commit 4a8f80a into dotnetcore:main Sep 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(ValidateForm): MetadataType 方式如果继承了 IValidateCollection 概率不显示单属性错误提示
2 participants