-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(JsonEnumConverter): remove core namespace #4531
Conversation
Reviewer's Guide by SourceryThis PR removes the Class diagram for namespace changes in JSON convertersclassDiagram
class JsonDescriptionEnumConverter {
<<JsonConverter>>
+ConvertToString()
+ConvertFromString()
}
class JsonEnumConverter {
<<JsonConverter>>
+ConvertToString()
+ConvertFromString()
}
JsonDescriptionEnumConverter --|> JsonConverter
JsonEnumConverter --|> JsonConverter
note for JsonDescriptionEnumConverter "Moved from BootstrapBlazor.Core.Converter to BootstrapBlazor.Components"
note for JsonEnumConverter "Moved from BootstrapBlazor.Core.Converter to BootstrapBlazor.Components"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- This namespace change could be breaking for external consumers. Consider documenting this as a breaking change in the release notes.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4531 +/- ##
===========================================
- Coverage 100.00% 99.97% -0.03%
===========================================
Files 631 631
Lines 27072 27072
Branches 3928 3928
===========================================
- Hits 27072 27065 -7
- Misses 0 7 +7 ☔ View full report in Codecov by Sentry. |
remove core namespace
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4530
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Chores: