Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(JsonEnumConverter): remove core namespace #4531

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Oct 24, 2024

remove core namespace

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4530

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Chores:

  • Remove the usage of the 'BootstrapBlazor.Core.Converter' namespace across multiple files.

Copy link

sourcery-ai bot commented Oct 24, 2024

Reviewer's Guide by Sourcery

This PR removes the BootstrapBlazor.Core.Converter namespace by moving the JSON converter classes to the BootstrapBlazor.Components namespace and updating all related imports.

Class diagram for namespace changes in JSON converters

classDiagram
    class JsonDescriptionEnumConverter {
        <<JsonConverter>>
        +ConvertToString()
        +ConvertFromString()
    }
    class JsonEnumConverter {
        <<JsonConverter>>
        +ConvertToString()
        +ConvertFromString()
    }

    JsonDescriptionEnumConverter --|> JsonConverter
    JsonEnumConverter --|> JsonConverter

    note for JsonDescriptionEnumConverter "Moved from BootstrapBlazor.Core.Converter to BootstrapBlazor.Components"
    note for JsonEnumConverter "Moved from BootstrapBlazor.Core.Converter to BootstrapBlazor.Components"
Loading

File-Level Changes

Change Details Files
Moved JSON converter classes to BootstrapBlazor.Components namespace
  • Changed namespace from BootstrapBlazor.Core.Converter to BootstrapBlazor.Components for JsonDescriptionEnumConverter
  • Changed namespace from BootstrapBlazor.Core.Converter to BootstrapBlazor.Components for JsonEnumConverter
src/BootstrapBlazor/Converter/JsonDescriptionEnumConverter.cs
src/BootstrapBlazor/Converter/JsonEnumConverter.cs
Removed unnecessary using directives for the old converter namespace
  • Removed using statement for BootstrapBlazor.Core.Converter namespace
src/BootstrapBlazor/Components/ThemeProvider/ThemeValue.cs
src/BootstrapBlazor/Options/ScrollIntoViewOptions.cs
src/BootstrapBlazor/Services/Serial/SerialPortFlowControlType.cs
src/BootstrapBlazor/Services/Serial/SerialPortParityType.cs
src/BootstrapBlazor/Services/Bluetooth/BluetoothServices.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#4530 Remove the BootstrapBlazor.Core.Converter namespace and move its contents to BootstrapBlazor.Components

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the chore This are tasks or bot action label Oct 24, 2024
@bb-auto bb-auto bot added this to the v8.10.0 milestone Oct 24, 2024
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Oct 24, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • This namespace change could be breaking for external consumers. Consider documenting this as a breaking change in the release notes.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (cf30213) to head (53334d5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main    #4531      +/-   ##
===========================================
- Coverage   100.00%   99.97%   -0.03%     
===========================================
  Files          631      631              
  Lines        27072    27072              
  Branches      3928     3928              
===========================================
- Hits         27072    27065       -7     
- Misses           0        7       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang disabled auto-merge October 24, 2024 06:57
@ArgoZhang ArgoZhang merged commit 229fedd into main Oct 24, 2024
4 of 5 checks passed
@ArgoZhang ArgoZhang deleted the refactor-core branch October 24, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore This are tasks or bot action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(JsonEnumConverter): remove core namespace
1 participant