-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FullScreen): remove FullScreen component #4537
Conversation
Reviewer's Guide by SourceryThis PR removes the FullScreen component and refactors the fullscreen functionality into a service-based approach. The implementation simplifies the JavaScript module by removing the data management layer and converts the component-based implementation into a more streamlined service implementation. Sequence diagram for toggling fullscreen modesequenceDiagram
participant User
participant FullScreenService
participant JSModule
User->>FullScreenService: Toggle(option, token)
FullScreenService->>JSModule: LoadModule("./_content/BootstrapBlazor/modules/fullscreen.js")
JSModule-->>FullScreenService: _module
FullScreenService->>JSModule: InvokeAsync("toggle", token, option)
JSModule-->>FullScreenService: Result
FullScreenService-->>User: Task Result
Updated class diagram for FullScreenServiceclassDiagram
class FullScreenService {
+JSModule _module
+Task Toggle(FullScreenOption? option, CancellationToken token)
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- The browser compatibility fallback chain is not working correctly (link)
Overall Comments:
- The browser prefix handling in enterFullscreen() needs to be fixed. The current OR (||) operator won't actually call the prefixed methods. Consider using: if (el.requestFullscreen) el.requestFullscreen(); else if (el.webkitRequestFullscreen) el.webkitRequestFullscreen(); etc.
Here's what I looked at during the review
- 🔴 General issues: 1 blocking issue
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4537 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 630 629 -1
Lines 27052 27044 -8
Branches 3927 3926 -1
=========================================
- Hits 27052 27044 -8 ☔ View full report in Codecov by Sentry. |
remove FullScreen component
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4536
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhancements: