-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ErrorLogger): redesign ErrorLogger component #4576
Conversation
Reviewer's Guide by SourceryThe PR redesigns the ErrorLogger component by introducing a new parameter to control global exception capturing and refactoring the error handling logic. The changes simplify the component's inheritance structure and improve its exception handling capabilities by delegating the core functionality to a new BootstrapBlazorErrorBoundary component. Sequence diagram for error handling in ErrorLoggersequenceDiagram
participant User
participant ErrorLogger
participant BootstrapBlazorErrorBoundary
participant Logger
participant ToastService
User->>ErrorLogger: Trigger error
ErrorLogger->>BootstrapBlazorErrorBoundary: RenderException(exception)
BootstrapBlazorErrorBoundary->>Logger: LogError(exception)
alt ShowToast is true
BootstrapBlazorErrorBoundary->>ToastService: Show error toast
end
BootstrapBlazorErrorBoundary->>ErrorLogger: Update state
ErrorLogger->>User: Display error content
Class diagram for redesigned ErrorLogger componentclassDiagram
class ErrorLogger {
+bool EnableErrorLogger
+Func<ILogger, Exception, Task> OnErrorHandleAsync
+RenderFragment ChildContent
+RenderFragment<Exception> ErrorContent
+Task HandlerExceptionAsync(Exception exception)
+void Register(IHandlerException component)
+void UnRegister(IHandlerException component)
}
class BootstrapBlazorErrorBoundary {
+Func<ILogger, Exception, Task> OnErrorHandleAsync
+bool ShowToast
+string ToastTitle
+Task RenderException(Exception exception, IHandlerException? handler)
}
ErrorLogger --> BootstrapBlazorErrorBoundary : uses
IErrorLogger <|.. ErrorLogger
IHandlerException <|.. BootstrapBlazorErrorBoundary
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
src/BootstrapBlazor/Components/ErrorLogger/BootstrapBlazorErrorBoundary.cs
Show resolved
Hide resolved
src/BootstrapBlazor/Components/ErrorLogger/BootstrapBlazorErrorBoundary.cs
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4576 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 622 622
Lines 26933 26856 -77
Branches 3923 3919 -4
=========================================
- Hits 26933 26856 -77 ☔ View full report in Codecov by Sentry. |
redesign ErrorLogger component
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4575
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Redesign the ErrorLogger component to enhance its functionality and introduce the BootstrapBlazorErrorBoundary component for improved exception handling.
New Features:
Enhancements:
Tests: