Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): missing scroll after toggle CardView mode #4600

Merged
merged 9 commits into from
Nov 2, 2024
Merged

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Nov 2, 2024

missing scroll after toggle CardView mode

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4574

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Fix the missing scroll issue when toggling CardView mode in the Table component and enhance the component by adding a toggleView function and using nullish coalescing for better code reliability.

Bug Fixes:

  • Fix the missing scroll functionality when toggling the CardView mode in the Table component.

Enhancements:

  • Improve the Table component by adding a toggleView function to handle view changes more effectively.
  • Enhance the Table component's JavaScript by replacing '||' with '??' for nullish coalescing, improving code readability and reliability.

Copy link

sourcery-ai bot commented Nov 2, 2024

Reviewer's Guide by Sourcery

This PR fixes a scrolling issue when toggling between CardView and TableView modes in the Table component. The implementation includes proper cleanup of table resources during view changes and improvements to null handling using nullish coalescing operators. The changes ensure scroll functionality is maintained when switching view modes and table resources are properly managed.

Sequence diagram for toggling between CardView and TableView

sequenceDiagram
    actor User
    participant TableComponent
    participant JavaScript

    User ->> TableComponent: Click CardView button
    TableComponent ->> JavaScript: toggleView(id)
    JavaScript ->> JavaScript: destroyTable(table)
    JavaScript ->> JavaScript: reset(id)
    JavaScript ->> TableComponent: Update view
    TableComponent ->> User: Display updated view with scroll
Loading

Updated class diagram for Table component

classDiagram
    class Table {
        - bool _viewChanged
        + void OnClickCardView()
        + Task OnAfterRenderAsync(bool firstRender)
    }

    note for Table "Added _viewChanged to track view changes"
    note for Table "OnClickCardView now sets _viewChanged to true"
    note for Table "OnAfterRenderAsync checks _viewChanged and calls toggleView if true"
Loading

File-Level Changes

Change Details Files
Added table resource cleanup and reinitialization when toggling between view modes
  • Added new toggleView function to handle view mode changes
  • Extracted table cleanup logic into a separate destroyTable function
  • Added proper cleanup of observer and event handlers
  • Set _viewChanged flag when switching view modes
  • Added view change detection and handling in OnAfterRenderAsync
src/BootstrapBlazor/Components/Table/Table.razor.js
src/BootstrapBlazor/Components/Table/Table.razor.cs
src/BootstrapBlazor/Components/Table/Table.razor.Edit.cs
Enhanced null handling in JavaScript code
  • Replaced '
Updated CSS classes for proper scrolling in CardView mode
  • Added 'scroll' class to table-card wrapper
src/BootstrapBlazor/Components/Table/Table.razor.cs
Enhanced demo examples with CardView functionality
  • Added ShowCardView property to table demos
  • Updated table configurations in fixed header examples
src/BootstrapBlazor.Server/Components/Samples/Table/TablesFixedHeader.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#4574 Fix horizontal scrolling of table header when switching between Card and Table modes with IsFixedHeader=true and ShowCardView=true

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the need-repro-project Need repro project label Nov 2, 2024
@bb-auto bb-auto bot added this to the v9.0.0 milestone Nov 2, 2024
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Nov 2, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider fixing the spelling of 'destoryTable' to 'destroyTable' for consistency
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

src/BootstrapBlazor/Components/Table/Table.razor.js Outdated Show resolved Hide resolved
@ArgoZhang ArgoZhang enabled auto-merge (squash) November 2, 2024 03:55
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (dd5b65b) to head (0ce7143).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4600   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          620       620           
  Lines        27390     27396    +6     
  Branches      3920      3921    +1     
=========================================
+ Hits         27390     27396    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang
Copy link
Collaborator Author

@sourcery-ai review

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang added bug Something isn't working and removed need-repro-project Need repro project labels Nov 2, 2024
@ArgoZhang ArgoZhang merged commit bcd80c5 into main Nov 2, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the fix-table branch November 2, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table组件表头不能水平滚动
1 participant