Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Editor): summernote jQuery upgrade to 3.6.0 #4633

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Nov 9, 2024

summernote jQuery upgrade to 3.6.0

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4632

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Upgrade the jQuery version used in the Summernote editor from 3.5.1 to 3.6.0 to address issue #4632.

Copy link

sourcery-ai bot commented Nov 9, 2024

Reviewer's Guide by Sourcery

The pull request upgrades the jQuery version used in the Summernote editor from 3.5.1 to 3.6.0. The implementation involves updating the script reference in the App.razor component to point to the new jQuery version.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated jQuery version from 3.5.1 to 3.6.0 for the Summernote editor
  • Changed script source reference from jquery-3.5.1.min.js to jquery-3.6.0.min.js
src/BootstrapBlazor.Server/Components/App.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#4632 Support dark theme The PR only upgrades jQuery from version 3.5.1 to 3.6.0, but does not implement any dark theme support functionality.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Nov 9, 2024
@bb-auto bb-auto bot added this to the v9.0.0 milestone Nov 9, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please document the testing performed to verify this jQuery upgrade doesn't introduce any breaking changes in the Summernote editor functionality.
  • Have you reviewed the jQuery 3.6.0 changelog to confirm there are no breaking changes that could affect Summernote? Please add this information to the PR description.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (17ed9ac) to head (2894526).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4633   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          620       620           
  Lines        27419     27419           
  Branches      3927      3927           
=========================================
  Hits         27419     27419           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dotnetcore dotnetcore deleted a comment from sourcery-ai bot Nov 9, 2024
@ArgoZhang
Copy link
Collaborator Author

@sourcery-ai review

@dotnetcore dotnetcore deleted a comment from sourcery-ai bot Nov 9, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please complete the risk assessment section in the PR template and provide justification for the selected risk level.
  • Could you document what testing was performed to verify that the jQuery upgrade doesn't impact any Summernote functionality?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit 67c2e18 into main Nov 9, 2024
4 checks passed
@ArgoZhang ArgoZhang deleted the feat-editor branch November 9, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(Editor): summernote jQuery upgrade to 3.6.0
1 participant