fix(ModalDialog): not shown after close previous window when set IsDraggable and IsCenter to true

[ArgoZhang]

not shown after close previous window when set IsDraggable and IsCenter to true

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符；如果有关联 Issue 请在下方填写相关编号

Description

fixes #4658

Regression?

• Yes
• No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

• High
• Medium
• Low

[Justify the selection above]

Verification

• Manual (required)
• Automated

Packaging changes reviewed?

• Yes
• No
• N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

• Doc is updated/provided or not needed
• Demo is updated/provided or not needed
• Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

• Fix the issue where the ModalDialog component was not shown after closing a previous window when both IsDraggable and IsCenter were set to true.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR fixes a bug in the ModalDialog component where it wasn't displaying correctly after closing a previous window when both IsDraggable and IsCenter properties were set to true. The implementation moves the centering logic from Modal.razor.js to ModalDialog.razor.js and introduces a _firstRender flag to ensure proper initialization.

Sequence diagram for ModalDialog rendering process

sequenceDiagram
    participant User
    participant ModalDialog
    participant JSInterop
    User->>ModalDialog: Open ModalDialog
    ModalDialog->>ModalDialog: OnInitialized()
    ModalDialog->>ModalDialog: OnParametersSet()
    ModalDialog->>ModalDialog: OnAfterRender(true)
    ModalDialog->>JSInterop: Initialize JS
    JSInterop-->>ModalDialog: JS Initialized
    ModalDialog->>User: ModalDialog Shown

Loading

Updated class diagram for ModalDialog component

classDiagram
    class ModalDialog {
        - bool _firstRender
        - DialogResult _result
        + OnInitialized()
        + OnParametersSet()
        + OnAfterRender(bool firstRender)
    }
    note for ModalDialog "Added _firstRender to handle initial rendering logic"

Loading

File-Level Changes

Change	Details	Files
Refactored modal dialog centering logic	Added _firstRender boolean flag to track initial render state Modified is-draggable-center class to consider _firstRender state Implemented OnAfterRender to manage _firstRender flag Moved centering calculation logic from Modal to ModalDialog component	src/BootstrapBlazor/Components/Modal/ModalDialog.razor.cs src/BootstrapBlazor/Components/Modal/Modal.razor.js src/BootstrapBlazor/Components/Modal/ModalDialog.razor.js

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#4658	Fix the issue where table's new record button dialog is not properly shown when embedded in a dialog service	✅

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

• Please add documentation comments explaining why the _firstRender flag is necessary and how it helps fix the positioning issue. This will help future maintainers understand the implementation.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f477aa4) to head (e7939f1).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #4663   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          620       620           
  Lines        27419     27427    +8     
  Branches      3928      3929    +1     
=========================================
+ Hits         27419     27427    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ArgoZhang]

@sourcery-ai review

[sourcery-ai]

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}