-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Widget): throw exception when dispose #4665
Conversation
Reviewer's Guide by SourceryThe PR improves the dispose functionality in the DropdownWidget component by adding proper event handler cleanup and null checks. The changes ensure that both 'shown' and 'hidden' dropdown events are properly unsubscribed when the component is disposed. Sequence diagram for DropdownWidget dispose processsequenceDiagram
participant User
participant DropdownWidget
participant EventHandler
User->>DropdownWidget: Call dispose(id)
DropdownWidget->>DropdownWidget: Get element by id
alt Element exists
DropdownWidget->>EventHandler: off(el, 'shown.bs.dropdown')
DropdownWidget->>EventHandler: off(el, 'hidden.bs.dropdown')
end
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- The PR title is misleading - the changes prevent exceptions rather than throwing them. Please update it to something like 'fix(Widget): prevent exceptions during disposal' or similar.
- Please complete the PR template fully in English to help with project tracking and maintenance. Several sections are currently incomplete or in Chinese.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4665 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 620 620
Lines 27427 27427
Branches 3929 3929
=========================================
Hits 27427 27427 ☔ View full report in Codecov by Sentry. |
throw exception when dispose
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4664
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: