Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Layout): adjust z-index value for Modal #4686

Merged
merged 7 commits into from
Nov 17, 2024
Merged

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Nov 17, 2024

adjust z-index value for Modal

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4685

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enhancements:

  • Adjust z-index values for layout components to improve stacking order.

Copy link

sourcery-ai bot commented Nov 17, 2024

Reviewer's Guide by Sourcery

The PR refactors the Layout component's z-index values and height calculations. It introduces CSS variables for height calculations, removes redundant CSS styles, and updates the layout structure to be more maintainable. The changes primarily focus on improving the stacking order of components and making the layout height calculations more flexible.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Adjusted z-index values for layout components to improve stacking order
  • Reduced z-index value from 1090 to 1035 for fixed header
  • Reduced z-index value from 1090 to 1035 for fixed footer
src/BootstrapBlazor/Components/Layout/Layout.razor.scss
Refactored height calculations using CSS variables
  • Added is-page class with 100vh height variable
  • Updated layout-main height calculation to use CSS variables
  • Changed fixed height values to use dynamic CSS variables
  • Replaced hardcoded 100vh values with --bb-layout-height variable
src/BootstrapBlazor/Components/Layout/Layout.razor.scss
Cleaned up and simplified CSS styles
  • Removed redundant menu demo styles
  • Simplified layout demo CSS variables
  • Updated menu component structure and styling
src/BootstrapBlazor.Server/Components/Samples/Menus.razor.css
src/BootstrapBlazor.Server/wwwroot/css/site.css
src/BootstrapBlazor.Server/Components/Samples/Menus.razor
Updated layout component logic and tests
  • Modified IsPage handling in Layout component
  • Updated unit tests for IsPage functionality
  • Removed unused IsOpen property
src/BootstrapBlazor/Components/Layout/Layout.razor.cs
test/UnitTest/Components/LayoutTest.cs
src/BootstrapBlazor.Server/Components/Layout/PageLayout.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#4685 Adjust z-index value for Modal component

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Nov 17, 2024
@bb-auto bb-auto bot added this to the v9.0.0 milestone Nov 17, 2024
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Nov 17, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The test coverage for Layout component was reduced by removing UseTabSet and IsFixedTabHeader checks. Please either restore these test cases or explain why they are no longer needed.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟡 Testing: 1 issue found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

test/UnitTest/Components/LayoutTest.cs Show resolved Hide resolved
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9a1b5cc) to head (3737b65).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4686   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          620       620           
  Lines        27388     27388           
  Branches      3929      3929           
=========================================
  Hits         27388     27388           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang
Copy link
Collaborator Author

@sourcery-ai review

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit 313ccb7 into main Nov 17, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the refactor-layout branch November 17, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(Layout): adjust z-index value for Modal
1 participant