Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Layout): update style for IsFixedTabHeader #4731

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Nov 25, 2024

update style for IsFixedTabHeader

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4730

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enhancements:

  • Update the style for the IsFixedTabHeader component to improve layout behavior.

@bb-auto bb-auto bot added the enhancement New feature or request label Nov 25, 2024
Copy link

sourcery-ai bot commented Nov 25, 2024

Reviewer's Guide by Sourcery

This PR updates the styling of fixed tab headers in the Layout component by replacing the previous margin and height calculation approach with a sticky positioning solution. The changes simplify the CSS structure while maintaining the fixed header functionality.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Simplified tab border card styling by removing unnecessary properties
  • Removed negative margin adjustment
  • Removed border and border-radius properties
  • Removed min-height calculation
src/BootstrapBlazor/Components/Layout/Layout.razor.scss
Replaced fixed tab header implementation with sticky positioning
  • Removed complex height calculations for layout-main
  • Removed overflow and height settings for tabs-body
  • Added sticky positioning for tabs-header
  • Added z-index to ensure proper stacking context
  • Removed footer height variable adjustment
src/BootstrapBlazor/Components/Layout/Layout.razor.scss

Assessment against linked issues

Issue Objective Addressed Explanation
#4730 Update the tabs-header style with position: sticky, top: var(--bb-layout-header-height), and z-index: 5

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the v9.0.0 milestone Nov 25, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please properly fill out the PR template, including risk assessment and verification details. This helps reviewers understand the impact of the changes.
  • Consider adding before/after screenshots to demonstrate the visual impact of these layout changes, particularly how the new sticky header behavior differs from the previous implementation.
  • The removal of margin, border, and height calculations represents a significant change. Please document how this might affect existing implementations and any migration steps if needed.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang enabled auto-merge (squash) November 25, 2024 04:52
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (333dd4d) to head (00ef1db).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4731   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          620       620           
  Lines        27391     27391           
  Branches      3921      3921           
=========================================
  Hits         27391     27391           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ArgoZhang ArgoZhang merged commit 195c0ab into main Nov 25, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the refactor-layout branch November 25, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(Layout): update style for IsFixedTabHeader
1 participant