Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(PopConfirmButton): add hover focus sample documentation #4735

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Nov 25, 2024

add hover focus sample documentation

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4734

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Documentation:

  • Add documentation for the PopConfirmButton component to demonstrate the use of hover and focus as trigger options.

Copy link

sourcery-ai bot commented Nov 25, 2024

Reviewer's Guide by Sourcery

This PR adds documentation and examples for the hover and focus trigger functionality of the PopConfirmButton component. The changes include adding new attribute documentation, a demo block showcasing the hover/focus trigger, and corresponding localization strings in both English and Chinese.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added documentation for new PopConfirmButton attributes
  • Added documentation for Trigger parameter with click/hover/focus options
  • Added documentation for ShowCloseButton parameter
  • Added documentation for ShowConfirmButton parameter
src/BootstrapBlazor.Server/Components/Samples/PopoverConfirms.razor.cs
Added new demo block for hover/focus trigger functionality
  • Created new demo section with hover/focus trigger example
  • Implemented example with custom styling and disabled buttons
src/BootstrapBlazor.Server/Components/Samples/PopoverConfirms.razor
Added localization strings for the new trigger demo
  • Added English translations for trigger demo title and description
  • Added Chinese translations for trigger demo title and description
src/BootstrapBlazor.Server/Locales/en-US.json
src/BootstrapBlazor.Server/Locales/zh-CN.json
Updated component code documentation
  • Enhanced Trigger property documentation to mention hover and focus options
src/BootstrapBlazor/Components/Button/PopConfirmButtonBase.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#4734 Implement auto-closing of Popover when clicking outside after it's opened The PR only adds documentation for existing hover/focus trigger functionality. It does not implement new auto-closing behavior when clicking outside the popover.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Nov 25, 2024
@bb-auto bb-auto bot added this to the v9.0.0 milestone Nov 25, 2024
@ArgoZhang ArgoZhang enabled auto-merge (squash) November 25, 2024 10:29
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (deaccd5) to head (991f14d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4735   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          620       620           
  Lines        27391     27391           
  Branches      3921      3921           
=========================================
  Hits         27391     27391           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ArgoZhang ArgoZhang merged commit 233ea83 into main Nov 25, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the doc-pop branch November 25, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(Popover): 能否实现点击按钮弹出 Popover 弹出框后,失去焦点时自动关闭?
1 participant